Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Catch errors in automation (instead of raise unexpected error) in Overkiz #135026

Merged

Conversation

iMicknl
Copy link
Contributor

@iMicknl iMicknl commented Jan 7, 2025

Proposed change

This logic was already implemented but accidentally used OverkizException, where it should have used BaseOverkizException. OverkizException is only used for unknown errors, while all other exceptions are specific and inherit from BaseOverkizException. (https://github.com/iMicknl/python-overkiz-api/blob/main/pyoverkiz/exceptions.py)

Will not solve #134803, but at least not shown an unknown exception on server errors.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iMicknl 👍

@gjohansson-ST gjohansson-ST added this to the 2025.1.2 milestone Jan 7, 2025
@gjohansson-ST gjohansson-ST merged commit 802ad55 into home-assistant:dev Jan 7, 2025
33 of 34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants