Fix channel retrieval for Reolink DUO V1 connected to a NVR #135035
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Fix channel retrieval for Reolink DUO V1 connected to a NVR.
The DUO V1 (not sold anymore) takes up 2 channels of a NVR, meaning 2 channels will have the same UID. The upstream library takes care of this by appending the channel to the UID giving the format for the total device ID:
{NVR UID}_{DUO V1 UID}_{channel integer}
.In the retrieval function of the channel the last
_{channel integer}
was skipped, this meant always the first of the two channels of the DUO camera would be returned, giving issues.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: