-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Upgrade boto3 to 1.20.24 + aiobotocore to 2.1.0 #64045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHjelmare
requested changes
Jan 13, 2022
MartinHjelmare
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@cdce8p I noticed some issues with current dev code related to this change when using
and also related to the way additional data are loaded. message_attributes = {}
if kwargs.get(ATTR_DATA):
message_attributes = {
k: {"StringValue": v, "DataType": "String"}
for k, v in kwargs[ATTR_DATA].items()
if v is not None
} We can investigate on discord if you have time. Simone |
Fixed :-) old code: import aiobotocore
session = aiobotocore.session.Aiosession() new code: from aiobotocore.session import AioSession
session = Aiosession() Simone |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Labels
cla-signed
dependency
dependency-bump
integration: amazon_polly
integration: aws
integration: route53
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Upgrade
boto3
to1.20.24
.Changelog: https://github.com/boto/boto3/blob/1.20.24/CHANGELOG.rst
Upgrade
aiobotocore
to2.1.0
.Changes: https://github.com/aio-libs/aiobotocore/blob/2.1.0/CHANGES.rst
Compare view: aio-libs/aiobotocore@1.2.2...2.1.0
This will help resolve a dependency conflict with
pyoverkiz==1.1.0
(which requires>=1.18.59
) from theoverkiz
integration.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: