Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix config_flow error from dlna_dmr for UPnP discovery info containing a single service #69977

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

chishm
Copy link
Contributor

@chishm chishm commented Apr 13, 2022

Proposed change

The SSDP config flow handler for dlna_dmr crashes when a device only defines a single service in its UPnP description. This is a fix for that case.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @StevenLooman, mind taking a look at this pull request as it has been labeled with an integration (dlna_dmr) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@frenck frenck merged commit 4e57b1b into home-assistant:dev Apr 13, 2022
@bdraco bdraco added this to the 2022.4.4 milestone Apr 13, 2022
@chishm
Copy link
Contributor Author

chishm commented Apr 14, 2022

Thank you both for the fast review and merge. These changes should be ok to cherry pick into the 2022.4 release.

balloob pushed a commit that referenced this pull request Apr 14, 2022
@balloob balloob mentioned this pull request Apr 14, 2022
Djelibeybi pushed a commit to Djelibeybi/home-assistant-core that referenced this pull request Apr 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2022
@chishm chishm deleted the dlna_dmr-discovery_service_list branch April 16, 2022 07:09
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dlna_dmr issues in HA core logs
7 participants