Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Suppress UpnpResponseError in SamsungTV #69984

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Apr 13, 2022

Proposed change

Suppress UpnpResponseError in SamsungTV

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet epenet added this to the 2022.4.4 milestone Apr 13, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 👍

@epenet
Copy link
Contributor Author

epenet commented Apr 13, 2022

@frenck I've made another adjustment as it seems the failure can also occur during the re-subscribe (based on the original error)

@frenck frenck merged commit 2b69dff into home-assistant:dev Apr 13, 2022
@epenet epenet deleted the samsungtv-UpnpResponseError branch April 13, 2022 16:21
@balloob balloob mentioned this pull request Apr 14, 2022
Djelibeybi pushed a commit to Djelibeybi/home-assistant-core that referenced this pull request Apr 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upnp errors in SamsungTV integration
5 participants