Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix panic when exit code does not have a cause #452

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

HeavyWombat
Copy link
Member

Fixes: #448

Use err.Error() of ExitCode interface since this has a nil check.

Move ExitCode into its own source file.

Fix TYPO in comment about error.

Fixes: #448

Use `err.Error()` of `ExitCode` interface since this has a nil check.

Move `ExitCode` into its own source file.

Fix TYPO in comment about error.
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.38%. Comparing base (2fdda00) to head (b1ec0fc).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/exitcode.go 66.66% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files          16       17    +1     
  Lines        2159     2159           
=======================================
  Hits         1757     1757           
  Misses        326      326           
  Partials       76       76           
Flag Coverage Δ
unittests 81.38% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HeavyWombat HeavyWombat merged commit aa39ba8 into main Mar 7, 2025
9 checks passed
@HeavyWombat HeavyWombat deleted the fix/panic branch March 7, 2025 13:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic nil pointer with v1.10.0
1 participant