Skip to content

Commit

Permalink
Fixing a community reported bug!
Browse files Browse the repository at this point in the history
  • Loading branch information
QuinnDamerell committed Aug 23, 2024
1 parent 88f18c5 commit ecc9b56
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion homeway/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!-- https://developers.home-assistant.io/docs/add-ons/presentation#keeping-a-changelog -->
<!-- This is used in the homeway UI to show updates, so keep it up to date. -->

## 1.4.0-3
## 1.4.0-5

- 🐋 Adding a standalone docker image! Using the built in Home Assistant addon is the best option, but for those who can't, they can now use docker!

Expand Down
2 changes: 1 addition & 1 deletion homeway/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ image: ghcr.io/homewayio/homeway/{arch}
# Note when this version number changes, we must make a release to start a docker container build immediately, since HA will start looking for the new version.
# Basically: Make the final commit -> test and check lint actions (if a docker change, push to docker-test to ensure it builds) -> bump the version number -> create GitHub release.
# UPDATE THE CHANGE LOG!
version: 1.4.4
version: 1.4.5
4 changes: 2 additions & 2 deletions homeway/homeway/mdns.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def TryToResolveIfLocalHostnameFound(self, url):
# Check if the hostname ends with .local, which is a special domain that we can resolve.
# We can't do a string contains, because there can be DNS names like "something.local.hostname.com"
hostnameLower = hostname.lower()
if hostnameLower.endswith(".local") or hostnameLower.endswith(".internal"):
if hostnameLower.endswith(".local") is False and hostnameLower.endswith(".internal") is False:
self.LogDebug("No local domain found in "+url)
return None

Expand Down Expand Up @@ -174,7 +174,7 @@ def _TryToResolve(self, domain):

# Since we do caching, we allow the lifetime of the lookup to be longer, so we have a better chance of getting it.
# Don't allow this to throw, so we don't get nosy exceptions on lookup failures.
answers = self.dnsResolver.resolve(domain, lifetime=3.0, raise_on_no_answer=False, source=localAdapterIp)
answers = self.dnsResolver.resolve(domain, lifetime=1.0, raise_on_no_answer=False, source=localAdapterIp)

# Look get the list of IPs returned from the query. Sometimes, there's a multiples. For example, we have seen if docker is installed
# there are sometimes 172.x addresses.
Expand Down
1 change: 0 additions & 1 deletion homeway/homeway_linuxhost/logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ def GetLogger(config, logsDir, logLevelOverride_CanBeNone) -> logging.Logger:
logLevelOverride_CanBeNone = logLevelOverride_CanBeNone.upper()
print("Dev config override log level from "+logLevel+" to "+logLevelOverride_CanBeNone)
logLevel = logLevelOverride_CanBeNone
logLevel = "DEBUG"

# Set the final log level.
logger.setLevel(logLevel)
Expand Down

0 comments on commit ecc9b56

Please # to comment.