Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: set service name in spring boot starter #315

Closed
wants to merge 10 commits into from

Conversation

JamieDanielson
Copy link
Contributor

@JamieDanielson JamieDanielson commented Jan 13, 2025

Which problem is this PR solving?

  • When using a non-classic API key... service.name is not properly set, resulting in traces ending up in wrong dataset. For example, with dataset=my-dataset and service.name=my-service, traces should show up in my-service dataset.

Short description of the changes

  • set service.name in spring boot starter
  • use process name instead of service name for default fallback
  • don't throw on runtime exception
  • update unit tests to assert ServiceName is properly used for dataset when sending
  • add example spring app for manual testing
  • fix some typos

TODO: handle classic key scenario for spring boot

@JamieDanielson JamieDanielson self-assigned this Jan 13, 2025
@JamieDanielson JamieDanielson added type: bug Something isn't working version: bump patch A PR with release-worthy changes and is backwards-compatible. labels Jan 13, 2025
@JamieDanielson JamieDanielson force-pushed the jamie.fix-service-name-spring branch from 66f31d1 to bd1eaa9 Compare January 14, 2025 16:02
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I'd recommend moving the removal of the bin dir and maybe the spelling changes into separate PRs so help keep each change concise.

@JamieDanielson
Copy link
Contributor Author

closing as this is now being split into two PRs

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: bug Something isn't working version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants