Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: support Classic Ingest Keys #193

Merged
merged 1 commit into from
Mar 6, 2024
Merged

feat: support Classic Ingest Keys #193

merged 1 commit into from
Mar 6, 2024

Conversation

jharley
Copy link
Contributor

@jharley jharley commented Mar 6, 2024 •
edited by MikeGoldsmith
Loading

Which problem is this PR solving?

We've now released Ingest Keys, but in order for them to work with Classic environments properly we need to update the key detection logic.

Short description of the changes

  • updates the Classic API Key detection logic to understand the shape of a Classic Ingest Key

@jharley jharley added type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible. labels Mar 6, 2024
@jharley jharley requested a review from a team as a code owner March 6, 2024 15:13
@jharley jharley self-assigned this Mar 6, 2024
@jharley jharley added the merge at will Reviewer can merge the PR once reviewed. label Mar 6, 2024
@jharley jharley merged commit d4ad210 into main Mar 6, 2024
6 checks passed
@jharley jharley deleted the jharley.ingest-key-support branch March 6, 2024 16:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees

@jharley jharley

Labels
merge at will Reviewer can merge the PR once reviewed. type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jharley @MikeGoldsmith