Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add a react native expo sample app #1

Merged
merged 7 commits into from
Feb 14, 2025
Merged

Conversation

beekhc
Copy link
Collaborator

@beekhc beekhc commented Feb 14, 2025

Which problem is this PR solving?

We've had several requests for examples of how to use Honeycomb with React Native apps. This example should fulfill that need, once we made this repo public.

Short description of the changes

This is mostly a default React Native Expo app. The main modified files that need to be reviewed are:

  • README.md
  • app/(tabs)/demo.tsx
  • app/honeycomb.tsx

How to verify that this has the expected result

I have manually run this app in the iOS simulator and verified that the intended telemetry shows up in Honeycomb.

Copy link
Collaborator

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few suggestions below. Still unsure about the error I'm getting locally but will continue to investigate.

beekhc and others added 6 commits February 14, 2025 12:32
Co-authored-by: Jamie Danielson <jamiedanielson@honeycomb.io>
Co-authored-by: Jamie Danielson <jamiedanielson@honeycomb.io>
Co-authored-by: Jamie Danielson <jamiedanielson@honeycomb.io>
Co-authored-by: Jamie Danielson <jamiedanielson@honeycomb.io>
Co-authored-by: Jamie Danielson <jamiedanielson@honeycomb.io>
Copy link
Collaborator

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, we'll circle back to sort out the web error from the newly introduced "exports" field in package.json. As it is here it works and that's what we want 🚀

@beekhc beekhc merged commit 8079de6 into main Feb 14, 2025
2 checks passed
@beekhc beekhc deleted the beeklimt.react-native-app branch February 14, 2025 22:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants