Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding Deno option for BFF and image-picker #6

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thisisjofrank
Copy link

Adding a Deno version of the backend-for-frontend-node

Ported BFF over to Oak and Oak router, instead of express.
Added a deno.json and some tasks to the image-picker to run in a more 'deno friendly' way.

How to verify that this has the expected result

Add your api key and use the deno tasks to run the services.

Copy link

github-actions bot commented Feb 27, 2025

Thank you for contributing to the project! 🎉

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Make sure to prepend with feat:, fix:, or another option in the list below.

Once you update the title, this workflow will re-run automatically and validate the updated title.

Details:

No release type found in pull request title "Adding Deno option for BFF and image-picker". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - maint
 - rel
 - fix
 - feat
 - chore
 - ci
 - docs
 - style
 - refactor
 - perf
 - test

@thisisjofrank thisisjofrank changed the title Adding Deno option for BFF Adding Deno option for BFF and image-picker Feb 27, 2025
Copy link

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to show that you don’t need to import any otel libraries to see something

@@ -0,0 +1,25 @@
import { NodeSDK } from '@opentelemetry/sdk-node';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed in Deno at all.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just have to start Deno with --unstable-otel and OTEL_DENO=true and it all just works OOTB.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants