-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adding Deno option for BFF and image-picker #6
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to the project! 🎉 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Make sure to prepend with Once you update the title, this workflow will re-run automatically and validate the updated title. Details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to show that you don’t need to import any otel libraries to see something
@@ -0,0 +1,25 @@ | |||
import { NodeSDK } from '@opentelemetry/sdk-node'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed in Deno at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You just have to start Deno with --unstable-otel
and OTEL_DENO=true
and it all just works OOTB.
Adding a Deno version of the backend-for-frontend-node
Ported BFF over to Oak and Oak router, instead of express.
Added a deno.json and some tasks to the image-picker to run in a more 'deno friendly' way.
How to verify that this has the expected result
Add your api key and use the deno tasks to run the services.