Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

r/honeycombio_board: removing "graph_settings" from query does not set all values to false #399

Open
jharley opened this issue Nov 18, 2023 · 0 comments
Labels

Comments

@jharley
Copy link
Collaborator

jharley commented Nov 18, 2023

Due to what I believe is a limitation of the Plugin SDKv2, when removing graph_settings from a board query the values will not be all set to false but instead left as they were previously in state.

Bug discovered while investigating another bug related to graph_settings (see: #400).

Likely fix is to reimplement the honeycombio_board resource in the new Plugin Framework (as has been done for the trigger and burn alert resource).

Steps to reproduce

Add a query to a board with graph_settings set, apply it, then after creation remove the query's graph_settings block. When you run plan/apply again there will be no changes to apply but terraform show retains the old values.

Additional context

Suggested workaround is to either leave graph_settings {} in the query or simply leave one or more settings as false. e.g.

resource "honeycombio_board" "myboard" {
[...]
  query {
    query_id = honeycombio_query.myquery.id
  
    graph_settings {
      utc_xaxis = false
    }
  }
}
@jharley jharley added the bug label Nov 18, 2023
jharley added a commit that referenced this issue Nov 20, 2023
…oved (#400)

When removing a setting from `graph_settings` the value is not reverted
to "false" (the documented default).

During testing #399 was discovered but I believe the fix there is to
re-implement the resource in the Plugin Framework.

Initially reported via Honeycomb Support.

---
- To see the specific tasks where the Asana app for GitHub is being
used, see below:
  - https://app.asana.com/0/0/1205951498507418
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant