Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: resolved npm_execpath issue #79

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Conversation

MathurAditya724
Copy link
Contributor

@MathurAditya724 MathurAditya724 commented Nov 28, 2024

Closes #52

  • Used event listener for the package manager.
  • Updated the hooks function to replace the $npm_execpath in package.json file.
  • Added === (triple equal sign) instead of == (double equal sign).

If the users haven't said yes to installation, we may not be able to get the package manager. For that, I have made npm the default value.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@MathurAditya724

Awesome! Let's ship it.

@yusukebe yusukebe merged commit 222dc97 into honojs:main Nov 29, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants