[Client types] make args param optional if the input has no required keys #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusukebe
reviewed
Oct 25, 2023
yusukebe
approved these changes
Oct 26, 2023
|
Oops. @MonsterDeveloper Could you run the command to prettify the code? |
|
@yusukebe done:) |
|
Oops! Please run |
|
Sorry, forgot about |
|
Perfect! I'll merge it now and release the new version including this later. Thank you very much!! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
ClientRequesttype, so theargsparam is only required if the input has required keys (specified by the validator).See #1583