ISSUE-603: Minor: Registry is failing to parse the doAs user #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guruchai
requested review from
kamalcph and
raju-saravanan
and removed request for
kamalcph
|
Please merge to CSP-3.0 as well. |
| @@ -461,8 +461,8 @@ protected static String getDoasUser(HttpServletRequest request) { | |||
| if (doAsUser.isEmpty()) { | |||
| return null; | |||
| } | |||
| break; | |||
There was a problem hiding this comment.
@guruchai : Will there be multiple "doAs" keys in the header ?
There was a problem hiding this comment.
@raju-saravanan It's query parameter, not header.
There was a problem hiding this comment.
@guruchai So multiple "doAs" query parameter ? Can you tell when there would be multiple "doAs" query parameters ?
There was a problem hiding this comment.
Sorry, with regards to the question, it does not make sense to have multiple doAs query parameters. Since the doAs is typically attached by a proxy server, it makes sense to pick the last one.
So break statement does not make sense. Thanks for pointing!
|
@raju-saravanan Can you check? |
raju-saravanan
approved these changes
Oct 10, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #603