Don't use WXUSINGDLL, use custom flag instead #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WXUSINGDLL may enabled by build system for something else and may not be what we are wanting for this library. Instead, use more library-specific JSON_USING_DLL and JSON_CREATING_DLL flags to control DLL import/export options. Also, don't use API_EXPORT (might conflict with something else), use JSON_API_EXPORT.
|
Technically it changes nothing. But you have a point on code readability. I will be merging this. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WXUSINGDLL may enabled by build systems for something else and may not be what we are wanting when building this library. Instead, use more library-specific JSON_USING_DLL and JSON_CREATING_DLL flags to control DLL import/export options.
Also, don't use API_EXPORT (might conflict with something else), use more specific JSON_API_EXPORT.