Create user overview page #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2019
localjo
force-pushed
the
user-overview
branch
from
eac9195 to
9fc01fd
Compare
localjo
force-pushed
the
user-overview
branch
from
e00e667 to
25c6ffc
Compare
|
Right now the footer is a part of the base template, and would be included on every page. I can move it to the landing page and remove it from the template, but it seems like the kind of thing that should be on every page for consistency and UX. |
|
@russbiggs I added the smaller footer here to all pages except the homepage. This PR is still waiting for the changes to campaign.json. |
localjo
force-pushed
the
user-overview
branch
from
d4656f0 to
ce8fa7d
Compare
This commit was squashed to resolve merge conflicts. It contains the following changes: Add page header Call updated when show details is done Campaign page layout WIP Add map toggle Finish basic styles for user page Move campaign map css The #campaign-map element exists on multiple pages so styles were interfering Only call updated if defined Add campaign view button Remove console.log Use small button variation Add campaign manage and view buttons Add warning label for less than 10 days 10 days is arbitary and we can set it to any number we want Make campaign list styles mobile friendly Add empty state for now projects Fix initial map render Set toggle off color to blue light Scope CSS rules better to avoid conflicts Fix finished badge for campaigns It was displaying negative numbers for finished campaigns Make list without map two columns Update select box functionality Make the select box work properly for all campaign types and eliminate some dead code Move my projects route to /user/id Also add a logged out state to /user/id and handle redirecting on login/out and updating the nav link Redirect user page on logout Add small footer Active on all pages except the home page for now
localjo
force-pushed
the
user-overview
branch
from
ce8fa7d to
44a4270
Compare
localjo
dismissed
russbiggs’s stale review
Made requested changes. Agreed via Slack to merge. Will update campaigns.json related items in another PR.
localjo
added a commit
that referenced
this pull request
Nov 12, 2019
I talked with Russ about this last night, and I'm going to go ahead and merge it to develop now because it's just some small bug fixes from #752
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #732
Basic markup and styles for this page are done. Left to do:
Update map styles and replace with mapbox-gl if possible (see Update all maps to MapboxGL #749 )Implement pagination of search results?develop