Detect cross-origin redirects during visits #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elying on javascript Fetch API, which has CORS limitations.
jayohms
commented
Jan 7, 2025
Comment on lines
+249
to
+250
| navigator.pop() | ||
| navigator.route(location) |
There was a problem hiding this comment.
Note this is where the redirect visit is initiated. First, it pops the current screen off the backstack, since it led to a visit failure. Then the new cross-origin redirect visit is routed, which will likely end up routing outside the app — but it's based on the configured RouteDecisionHandler instances.
mbarta
approved these changes
Jan 8, 2025
core/src/main/kotlin/dev/hotwire/core/turbo/http/HttpRepository.kt
Outdated
Show resolved
Hide resolved
…ts own data class
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes the approach in hotwired/turbo-android#325. Due to CORS restrictions, the javascript
FetchAPI cannot be reliably used across applications to detect cross-origin redirects during Turbo visits.This new approach hands off failed visits with a non-HTTP status code (which suggests a cross-origin redirect may have been attempted) to the native code to detect cross-origin redirects. If a visit redirect is detected, the final redirect
locationis used to propose a new visit, which will flow through the normal navigation routing decision tree.