Improve screenshot performance #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: Rename the request result class and move the redirect properties to its own data class Detect cross-origin visit redirects natively via OkHttp, instead of relying on javascript Fetch API, which has CORS limitations. Allow cross-origin redirects from link clicks to propose a new visit
…eenshot-performance * origin/screenshot-performance: Rename the request result class and move the redirect properties to its own data class Detect cross-origin visit redirects natively via OkHttp, instead of relying on javascript Fetch API, which has CORS limitations. Allow cross-origin redirects from link clicks to propose a new visit
mbarta
commented
Jan 9, 2025
navigation-fragments/src/main/java/dev/hotwire/navigation/util/HotwireViewScreenshotHolder.kt
Outdated
Show resolved
Hide resolved
…eenshot-performance * origin/screenshot-performance: Refactoring
jayohms
approved these changes
Jan 9, 2025
navigation-fragments/src/main/java/dev/hotwire/navigation/util/HotwireViewScreenshotHolder.kt
Outdated
Show resolved
Hide resolved
navigation-fragments/src/main/java/dev/hotwire/navigation/util/HotwireViewScreenshotHolder.kt
Outdated
Show resolved
Hide resolved
navigation-fragments/src/main/java/dev/hotwire/navigation/util/HotwireViewScreenshotHolder.kt
Outdated
Show resolved
Hide resolved
...ation-fragments/src/main/java/dev/hotwire/navigation/fragments/HotwireWebFragmentDelegate.kt
Outdated
Show resolved
Hide resolved
navigation-fragments/src/main/java/dev/hotwire/navigation/util/HotwireViewScreenshotHolder.kt
Outdated
Show resolved
Hide resolved
jayohms
reviewed
Jan 9, 2025
navigation-fragments/src/main/java/dev/hotwire/navigation/util/HotwireViewScreenshotHolder.kt
Show resolved
Hide resolved
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the original
View.drawToBitmapway of capturing screenshots for HotwireView with a modern and more performant PixelCopy API.Along with this, the screenshot properties have been extracted to a
HotwireScreenshotHolderto improve code organisation.Using the old canvas -> bitmap drawing approach produced wildly inconsistent times to create a bitmap. Sometimes taking over 300-450ms:
Using the
PixelCopyAPI is much faster and more consistent, typically under 20ms to produce a bitmap: