Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add missing non async reply functions #31

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

svara
Copy link
Collaborator

@svara svara commented Feb 28, 2024

This PR adds the missing non async reply functions:

  • reply(to event: String, with jsonData: String, completion: ReplyCompletionHandler? = nil)
  • reply<T: Encodable>(to event: String, with data: T, completion: ReplyCompletionHandler? = nil)

@svara svara requested a review from joemasilotti February 28, 2024 10:29
@svara svara mentioned this pull request Feb 28, 2024
@joemasilotti
Copy link
Member

Ah, good catch! Thanks for this.

@joemasilotti joemasilotti merged commit cb3cdb3 into async-javascript-take-2 Feb 28, 2024
1 check passed
@joemasilotti joemasilotti deleted the async-javascript-take-2-replies branch February 28, 2024 14:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants