docs: Call super in shouldNavigateTo override
#214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since hotwired#163, the base implementation of `shouldNavigateTo` is useful because it checks for invalid URLs. So if you override this method we should still recommend you call `super` to get the base implementation. While here I turned the `when` into an `if` per [this](https://kotlinlang.org/docs/coding-conventions.html#if-versus-when), but I'm certainly not a Kotlin expert and happy to change it back if you prefer.
|
@ghiculescu Thanks for this recommendation. I'm thinking it should probably be easier to register your domain with the library, so by default the library takes care of this logic on its own 🤔. This recommendation actually leaves an open to spoofed urls like: I need to think about this, but I think we need a new default implementation that allows you to register your app's domain. |
|
Closing this since we have plans to better handle domain/routing logic in a more comprehensive way. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #163, the base implementation of
shouldNavigateTois useful because it checks for invalid URLs. So if you override this method we should still recommend you callsuperto get the base implementation.While here I turned the
wheninto anifper this, but I'm certainly not a Kotlin expert and happy to change it back if you prefer.