Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix R8 build issues #284

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Fix R8 build issues #284

merged 5 commits into from
Aug 29, 2023

Conversation

jayohms
Copy link
Collaborator

@jayohms jayohms commented Aug 29, 2023

This fixes release build issues after upgrading to AGP 8.x:

> Task :turbo:minifyProfilingWithR8 FAILED
ERROR: Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in /Users/johms/Work/hotwired/turbo-android/turbo/build/outputs/mapping/profiling/missing_rules.txt.
ERROR: R8: Missing class java.lang.invoke.StringConcatFactory (referenced from: java.lang.String dev.hotwire.turbo.config.TurboPathConfiguration$Location.toString() and 27 other contexts)

@jayohms jayohms requested a review from jhutarek August 29, 2023 21:51
@jayohms jayohms merged commit c81c90b into main Aug 29, 2023
@jayohms jayohms deleted the fix-build branch August 29, 2023 22:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jhutarek jhutarek Awaiting requested review from jhutarek

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jayohms