Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Nearly unresponsive when used with large collection of icons (~10'000 icons) #8

Closed
idflood opened this issue Sep 21, 2018 · 2 comments

Comments

@idflood
Copy link
Contributor

idflood commented Sep 21, 2018

A client purchased the icon pack from https://streamlineicons.com/ , but when opening the picker modal the browser become unresponsive until the modal is closed (scrolling happend 4 or more seconds later, …).

(I will try to propose an alternative script which lazy load/display the icons)

idflood added a commit to idflood/acf-icon-picker that referenced this issue Sep 24, 2018
houke added a commit that referenced this issue Oct 2, 2018
only append visible svg items in modal for perf, #8
@houke
Copy link
Owner

houke commented Oct 2, 2018

Thanks for the performance update! We've never used that many icons, so never had that issue ;).

@houke houke closed this as completed Oct 2, 2018
@idflood
Copy link
Contributor Author

idflood commented Oct 2, 2018

@houke tanks for the merge : ) I will probably come back with another merge request later with some small tweaks and fine tuning. And thanks for the plugin, it is incredibly useful 👍

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants