Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Docker improvements #257

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Docker improvements #257

wants to merge 2 commits into from

Conversation

Wilfred
Copy link
Contributor

@Wilfred Wilfred commented Jul 28, 2017

This makes two changes to the Docker build:

  • It excludes the Dockerfile from the build process, so we can make changes to the Dockerfile and Docker uses its layer cache
  • It changes the container to run as a hound user rather than root, according to docker best practices. This also makes it possible to run the Hound container on an NFS mount with root squashing.

Wilfred added 2 commits July 28, 2017 13:46
@Wilfred
Ignore changes to the Dockerfile
8b243c0 
Otherwise, any change to the Dockerfile invalidates the Docker cache,
and we re-run every step after `COPY .`.
@Wilfred
Don't run the container as root
8fb3e11 
Docker best practices discourage running as root:
https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#user
and it also enables Hound to run on a NFS share with root squashing.
Base automatically changed from master to main February 24, 2021 17:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wilfred @salemhilal