middleware.py: Django 1.10 fix #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lampslave
reviewed
Jan 10, 2017
| @@ -2,6 +2,11 @@ | |||
| from online_status.conf import online_status_settings as config | |||
| from online_status.status import refresh_user, refresh_users_list, OnlineStatus | |||
|
|
|||
| try: | |||
There was a problem hiding this comment.
This change can't fix anything, because MiddlewareMixin is not used.
There was a problem hiding this comment.
yes thanks I have added it now
|
Please add 1.10 into tox.ini and travis.yml to test your changes. |
Swap legacy render_to_response with render
Fix order of render args
Typo
Missing request arg
Missing comma
|
Added tests and fixed a render shortcut issue |
|
Could you please squash last commits? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.