Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

provisioning "thin' and compression "",should result in ERROR instead of creating thin volume #710

Closed
c-raghav opened this issue Aug 5, 2019 · 6 comments
Assignees

Comments

@c-raghav
Copy link

c-raghav commented Aug 5, 2019

provisioning "thin' and compression "",should result in ERROR instead of creating thin volume

Provisioning Compression Result

thin “” ERROR

@c-raghav
Copy link
Author

c-raghav commented Aug 7, 2019

proisioning ="" and compression "", is resulting in creating thin volume instead of erroring out , this needs to address

@c-raghav
Copy link
Author

creating volume with size = "0" or size = o

it still creates volume of size 1024 MB in the backed.
But inspect show size = 0

Since we are restricting the case of provisioning ="" and compression "",

This also we need to address, by restricting creation with proper message

@bhagyashree-sarawate
Copy link
Contributor

Assign to me, need discussion with imran

bhagyashree-sarawate added a commit to bhagyashree-sarawate/python-hpedockerplugin that referenced this issue Aug 21, 2019
@amitk1977 amitk1977 added low and removed medium labels Aug 22, 2019
sneharai4 pushed a commit that referenced this issue Sep 3, 2019
* fix for #718,#714,#711

* fixed uts related to message change

* Added fix for #710

* Modified document as per review comment

* fixed pep8 issues

* done review comment
@bhagyashree-sarawate
Copy link
Contributor

Fixed and merged

@amitk1977
Copy link
Collaborator

Raghavendra C to verify and close

@c-raghav
Copy link
Author

c-raghav commented Oct 4, 2019

Verified and find the output below

[root@cssosbe01-196113 hpedockerplugin]# docker volume create -d hpe --name test-defect -o size=10 -o provisioning=thin -o compression=""
Error response from daemon: create test-defect: create volume failed, error is: passed compression parameter does not have a valid value. Valid values are: ['true', 'false']

[root@cssosbe01-196113 hpedockerplugin]# docker volume create -d hpe --name test-defect -o size=10 -o provisioning="thin" -o compression=""
Error response from daemon: create test-defect: create volume failed, error is: passed compression parameter does not have a valid value. Valid values are: ['true', 'false']

[root@cssosbe01-196113 hpedockerplugin]# docker volume create -d hpe --name test-defect -o size=10 -o provisioning="" -o compression=""
Error response from daemon: create test-defect: create volume failed, error is: passed compression parameter does not have a valid value. Valid values are: ['true', 'false']

[root@cssosbe01-196113 hpedockerplugin]# docker volume create -d hpe --name test-defect -o size=0 -o provisioning="thin"
Error response from daemon: create test-defect: Please enter the valid integer value for size parameter

@c-raghav c-raghav closed this as completed Oct 4, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants