Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

. #282

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

. #282

wants to merge 7 commits into from

Conversation

sprytex
Copy link

@sprytex sprytex commented Jan 18, 2025

No description provided.

@iamnoksio
Copy link

For the 109:
Can you show me logs where locX,Y or Z are NaN? Same for health

Copy link

@iamnoksio iamnoksio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it tested?

@sprytex
Copy link
Author

sprytex commented Jan 31, 2025

is it tested?

yes

Copy link
Collaborator

@uRyanxD uRyanxD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is preferable to have 1 pull request for each patch

}

- return (EnchantmentManager.b.a + 1 >> 1) + EnchantmentManager.a.nextInt((EnchantmentManager.b.a >> 1) + 1);
+ return (EnchantmentManager.b.a + 1 >> 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add PandaSpigot comment

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And since this changes the vanilla default, add an option in the config

import java.util.concurrent.atomic.AtomicIntegerFieldUpdater;
import java.util.HashSet;

+import org.bukkit.Bukkit;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary import

import com.google.common.primitives.Doubles;
import com.google.common.primitives.Floats;
import com.google.common.util.concurrent.Futures;
+import com.hpfxd.pandaspigot.config.PandaSpigotConfig;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to say this in a simple way, but instead of importing it is preferable to use com.hpfxd.pandaspigot.config.PandaSpigotConfig.get() directly below, to avoid unnecessary diff

// CraftBukkit start
if (this.player.dead) return;

+ // Rejomy patch Use packets while inventory is open.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change comments to "// PandaSpigot start", "// PandaSpigot end"


public void e(NBTTagCompound nbttagcompound) {
try {
+ // FlamePaper start - Reset NaN Entity Values
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change comments to "// PandaSpigot start", "// PandaSpigot end"

@Override
public double getHealth() {
- return health;
+ return Double.isNaN(health) ? 0.0D : health; // FlamePaper - Reset NaN Entity Values
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change comment to "// PandaSpigot -",

From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: necrozma <necrozma999@gmail.com>
Date: Fri, 14 Jul 2023 22:16:17 -0600
Subject: [PATCH] Ensure correct attack damage on slot change
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly @ThatApplePieGuy closed the original pullrequest because the patch didn't fix the problem 100%

From 750a22a1f122a92275eebd14b555ea0482010b54 Mon Sep 17 00:00:00 2001
From: LinsaFTW <25271111+linsaftw@users.noreply.github.com>
Date: Fri, 13 Jan 2023 17:02:17 -0300
Subject: [PATCH] Reset NaN Entity Values
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can these values ​​be null? Exploits?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants