-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Inverted comma #223
Inverted comma #223
Conversation
Bring fork up to date
Some countries uses the inverted comma as a thousander separator
HTML entities
Hah, this is interesting. How do you type the inverted comma on a US keyboard? |
You‘re right, the inverted comma is not the right char; instead it is an apostrophe which is used and this should also be available on an US keyboard. I will make ab update on this. |
Yup, it seems that you're using right single quote |
Changed the sign to apos
@marcobischoff: Why do you try to solve #220 with this PR? I'm confused. Also, please use I think it would be best if you create a clean (new) PR with only the changes necessary to fix #222. |
@hql287 My repo is/was a little bit messed up. I will create a new PR. |
@marcobischoff Thanks! 👍 |
#222 As there are some countries which uses the inverted comma as thousand separator I've added this to the currency.