close issue: #79, fix exit with 0 when hint errors

attr-unsafe-chars(rule): exclude `\r\n`
htmlhint · Oct 9, 2015 · 30860c9 · 30860c9
1 parent de8d955
commit 30860c9
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/CHANGE.md b/CHANGE.md
@@ -1,7 +1,7 @@
 HTMLHint change log
 ====================
 
-## ver 0.9.9 (2015-10-8)
+## ver 0.9.9 (2015-10-10)
 
 add:
 
@@ -10,7 +10,9 @@ add:
 
 fix:
 
-1. fix end event col
+1. close issue: #79, fix exit with 0 when hint errors
+2. fix end event col
+2. attr-unsafe-chars(rule): exclude `\r\n`
 
 ## ver 0.9.8 (2015-10-7)
 

diff --git a/TODO.md b/TODO.md
@@ -1,3 +1,4 @@
 TODO
 ==================
 
+security rule
diff --git a/lib/htmlhint.js b/lib/htmlhint.js
diff --git a/src/rules/attr-unsafe-chars.js b/src/rules/attr-unsafe-chars.js
@@ -11,7 +11,8 @@ HTMLHint.addRule({
             var attrs = event.attrs,
                 attr,
                 col = event.col + event.tagName.length + 1;
-            var regUnsafe = /[\u0000-\u001f\u007f-\u009f\u00ad\u0600-\u0604\u070f\u17b4\u17b5\u200c-\u200f\u2028-\u202f\u2060-\u206f\ufeff\ufff0-\uffff]/;
+            // exclude \r\n
+            var regUnsafe = /[\u0000-\u0009\u000b-\u000c\u000d-\u001f\u007f-\u009f\u00ad\u0600-\u0604\u070f\u17b4\u17b5\u200c-\u200f\u2028-\u202f\u2060-\u206f\ufeff\ufff0-\uffff]/;
             for(var i=0, l=attrs.length;i<l;i++){
                 attr = attrs[i];
                 if(regUnsafe.test(attr.value) === true){
@@ -20,4 +21,4 @@ HTMLHint.addRule({
             }
         });
     }
-});
+});