Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

use extatic (a fork of ecstatic that will continue being maintained) #541

Closed
wants to merge 2 commits into from

Conversation

Xmader
Copy link
Contributor

@Xmader Xmader commented Jun 16, 2019

Please ensure that your pull request fulfills these requirements:

  • The pull request is being made against the master branch
  • Tests for the changes have been added (for bug fixes / features)

What is the purpose of this pull request? (bug fix, enhancement, new feature,...)

Fixes #525
Fixes #502

What changes did you make?

use extatic (a fork of ecstatic that will continue being maintained) instead of the original ecstatic since ecstatic is unmaintained and deprecated

Provide some example code that this change will affect, if applicable:

N/A

@Xmader Xmader changed the title use extatic (a fork of ecstatic) use extatic (a fork of ecstatic that will continue being maintained) Jun 16, 2019
@ghost

This comment has been minimized.

@wookayin

This comment has been minimized.

@thornjad
Copy link
Member

I'm not opposed to this, since it may provide a few benefits. We're very slowly working on rewriting http-server, possibly absorbing ecstatic's functionality into this repo, so this may end up being just a stop-gap for just the next two versions or so, would that be alright?

Also, we need to merge or rebase master here, especially because there's been an important update to vows that we need to get tests running.

@thornjad thornjad added this to the v0.13.0 milestone Dec 21, 2019
@thornjad thornjad added the major version Major, potentially breaking, change label Dec 21, 2019
(since it has been fixed in extatic)
@tchakabam
Copy link

@thornjad is http-server now still relying on ecstatic, or this fork, or has "absorbed" the functionality?

because the package.json here still seems to refer to a version prior the critical security fix,

see GHSA-jc84-3g44-wf2q

and which got fixed with a v4.1.3 release ecstatic, see

jfhbrook/node-ecstatic@72044b8

and

https://github.com/jfhbrook/node-ecstatic/releases/tag/4.1.3

(which doesn't however change the fact the original project is officially deprecated and not maintained anymore)

The critical question here being, isn't http-server as well exposed to the above mentioned exploit threat?

(actually asking as http-server is used in a customers projects for a currently-still-testing-setup, but still...)

@thornjad
Copy link
Member

thornjad commented Jul 6, 2021

Closing in favor of #693

@thornjad thornjad closed this Jul 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
major version Major, potentially breaking, change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERR_INVALID_REDIRECT when running http-server NULL byte in request path kills server
4 participants