Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add support for Access-Control-Expose-Headers using 'cors' configurat… #546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for Access-Control-Expose-Headers using 'cors' configurat… #546

wants to merge 1 commit into from

Conversation

J-Rojas
Copy link

@J-Rojas J-Rojas commented Jul 19, 2019

Fix #545. Supply 'corser' with a similar set of responseHeaders from the 'cors' options.

@github-actions
Copy link

This pull request has been inactive for 360 days

@github-actions github-actions bot added the stale label Aug 20, 2021
@thornjad thornjad removed the stale label Aug 20, 2021
@thornjad thornjad modified the milestone: v14.0 Aug 20, 2021
@thornjad thornjad added the minor version non-breaking, non-trivial change label Aug 20, 2021
thornjad
thornjad requested changes Aug 20, 2021
View reviewed changes
Copy link
Member

@thornjad thornjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way this looks! Only two items left to do:

  • Merge master again, there are new tests to run on this PR
  • Add this header to the CORS test in test/main.test.js

@thornjad thornjad added enhancement patch version Small, non-breaking, bug fix or trivial change and removed minor version non-breaking, non-trivial change labels Oct 15, 2021
ben-z added a commit to ben-z/http-server that referenced this pull request Apr 11, 2023
@ben-z
Add support for Access-Control-Expose-Headers and default CORS header…
8aa6a8f 
…s to CORS-safelisted headers

Similar to this (stale) PR: http-party#546
Resolves http-party#545
Usable for cruise-automation/webviz#247
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thornjad thornjad thornjad requested changes

Assignees
No one assigned
Labels
enhancement patch version Small, non-breaking, bug fix or trivial change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for 'Access-Control-Expose-Headers' using --cors
2 participants
@J-Rojas @thornjad