Skip to content

feat: make HttpClient dyn-clonable #92

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fishrock123
Copy link
Member

Kinda reverts #48

Related to http-rs/surf#237

Desirable for Surf-level config.

Kinda reverts http-rs#48

Related to http-rs/surf#237

Desirable for Surf-level config.
@Fishrock123
Copy link
Member Author

Turns out this still doesn't really work for surf config because Arc::make_mut() is only able to use Clone's .clone() internally, and dyn Thing can't be cloned, because stack sizing or something along those lines.

@Fishrock123 Fishrock123 closed this Jul 5, 2021
@Fishrock123 Fishrock123 reopened this Jul 5, 2021
@Fishrock123 Fishrock123 marked this pull request as draft July 5, 2021 22:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant