-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use JDK platform APIs for ALPN negotiation #522
Conversation
The tests are passing for me reliably when running them locally. They also passed once before in CI, because I got to the mima checks. I can't tell if there's an issue with my changes. |
It seems the same is happening in #520. |
Oh, uh, @hamnis (I think) found something related to a localhost change in http4s main repo. |
The failing tests might be http4s/http4s@2836af0. |
Nope, those tests run on the wildcard address. |
There's a better solution on the server part, I'll keep iterating on this. |
I'm actually really happy how this turned out. I anticipated it would be much worse to do the switch. |
Will rebase on #524 when that is merged. Edit: Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice.
|
||
### Requirements | ||
Blaze requires a modern, supported version of the JVM to build and run, as it relies on server APIs unavailable before | ||
[JDK8u252](https://webtide.com/jetty-alpn-java-8u252/). Any JDK newer than JDK8u252, including 9+ is supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is only strictly true for HTTP/2, but it's such good advice anyway, I'm happy not to qualify it.
Before (curl output):
After (curl output):