Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Release v6.0.0 #790

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Release v6.0.0 #790

wants to merge 1 commit into from

Conversation

ixti
Copy link
Member

@ixti ixti commented Aug 28, 2024

No description provided.

@ixti
Copy link
Member Author

ixti commented Aug 28, 2024

@tarcieri if that looks good to you - I will cut the release

@ixti ixti requested a review from tarcieri August 28, 2024 15:24
@tarcieri
Copy link
Member

Are there actually any breaking changes?

@ixti
Copy link
Member Author

ixti commented Aug 28, 2024

I believe #776 and #783 are.

Also, I just noticed a PR that I wanted to merge 4 years ago and never get to it, that I believe we should add in the release. The change will be in how readpartial work to make it more IO-alike (raising EOFError when the end is reached instead of silent empty chunk). See: #618

@ixti
Copy link
Member Author

ixti commented Aug 28, 2024

Alternative - I can cherry pick retriable and headers caching and cut 5.3.0 release instead.

@tarcieri
Copy link
Member

I’d definitely like to roll forward rather than backward, but v6.0.0 would be a great time to update the timeout subsystem: #773

@ixti
Copy link
Member Author

ixti commented Aug 28, 2024

Will merge #773

@tarcieri
Copy link
Member

#773 is an issue, not a PR. Perhaps we should ping the people mentioned in that issue to see if they can open a PR, though

@ixti
Copy link
Member Author

ixti commented Aug 29, 2024

Oh, I have confused it with #754 indeed

@tarcieri
Copy link
Member

tarcieri commented Sep 5, 2024

I made a last call for breaking changes to the timeout subsystem in #773, though perhaps we should merge #754 first as well

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants