Skip to content

Commit

Permalink
Go ahead and disable type stripping during testing entirely
Browse files Browse the repository at this point in the history
We'll need to support this soon, since it'll end up being default on
everybody's machine, but right now it breaks a bunch of stuff and it's
not an immediately useful feature.
  • Loading branch information
pimterry committed Jan 29, 2025
1 parent 601b956 commit 73ca28a
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ jobs:
cache: 'npm'
cache-dependency-path: 'package.json'

# The new type stripping breaks our existing ts-node testing
# set up, so disable it:
- name: Set Node Options for Node 23
if: startsWith(matrix.node-version, '23')
run: echo "NODE_OPTIONS=--no-experimental-strip-types" >> $GITHUB_ENV

- run: npm install
- run: npm run ci-tests

Expand Down

0 comments on commit 73ca28a

Please # to comment.