Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expect should be a list header #203

Closed
mnot opened this issue Mar 25, 2019 · 7 comments
Closed

Expect should be a list header #203

mnot opened this issue Mar 25, 2019 · 7 comments
Assignees

Comments

@mnot
Copy link
Member

mnot commented Mar 25, 2019

In bis, we locked down Expect to a single value, 100-continue. That's probably a bug; it needs to act like a list header still, even though it only has one allowed value. We might have to define error handling here too.

@mcmanus
Copy link

mcmanus commented Mar 25, 2019

ietf104: no concerns raised about adopting a list format

@reschke
Copy link
Contributor

reschke commented Mar 26, 2019

I guess we then need to pull in the full old ABNF:

   Expect       =  "Expect" ":" 1#expectation

   expectation  =  "100-continue" | expectation-extension
   expectation-extension =  token [ "=" ( token | quoted-string )
                            *expect-params ]
   expect-params =  ";" token [ "=" ( token | quoted-string ) ]

and then simplify it to:

   Expect       =  "Expect" ":" 1#expectation

   expectation =  token [ "=" ( token | quoted-string ) *expect-params ]
   expect-params =  ";" token [ "=" ( token | quoted-string ) ]

...and then define that the only expection that exists is "100-continue" with no parameters...

@reschke
Copy link
Contributor

reschke commented Mar 26, 2019

I wonder whether we can use parameter here - note that the old ABNF comes from 2616 which had implied LWS.

@annevk
Copy link
Contributor

annevk commented Mar 26, 2019

From other header parsing tests I've done I'd expect the processing model to be "split on comma and strip whitespace" and then see if any resulting token is an ASCII-case-insensitive match for 100-continue.

@reschke
Copy link
Contributor

reschke commented Jul 31, 2020

This introduced a bug - "*parameter" does not work, as "parameter" does not include the ";" delimiter.

royfielding added a commit that referenced this issue Aug 1, 2020
fix parameter ABNF for "expect" - broken by previous change (#203)
@mnot
Copy link
Member Author

mnot commented Aug 3, 2020

This can now be closed, correct?

@reschke
Copy link
Contributor

reschke commented Aug 3, 2020

Yes.

# for free to join this conversation on GitHub. Already have an account? # to comment
Development

No branches or pull requests

4 participants