Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MOAR mustaches! #599

Merged
merged 1 commit into from
Dec 31, 2013
Merged

MOAR mustaches! #599

merged 1 commit into from
Dec 31, 2013

Conversation

cannikin
Copy link
Contributor

mustachify.me has six different mustaches these days!

0

1

2

3

4

5

@iangreenleaf
Copy link
Contributor

👍 Critical upgrade

@technicalpickles
Copy link
Member

Given github/hubot-scripts#1113, I think it'd make sense for the scripts in hubot (not hubot-scripts) to be moved to their own things as well.

Thoughts?

@cannikin
Copy link
Contributor Author

What do you mean by "moved to their own things"? Moved to npm packages?

I thought the idea with the included scripts was to give someone downloading/installing hubot for the first time a great bootstrap set of scripts to get started. I was able to git clone and then go right to src/scripts and start adding/modifying my own.

It's been a while since I used npm for anything, but aren't they installed in a dot directory locally or in your user directory somewhere? That doesn't feel like as pleasant of a first run experience. :(

@technicalpickles
Copy link
Member

What do you mean by "moved to their own things"? Moved to npm packages?

Yep.

I thought the idea with the included scripts was to give someone downloading/installing hubot for the first time a great bootstrap set of scripts to get started.

I'm not sure what the original motivation to be honest, was started way before I started :) The problem with including scripts here is that they can change over time, but existing hubot installs have no way of manually updating them.

I was able to git clone and then go right to src/scripts and start adding/modifying my own.

That actually isn't the way to start a hubot anymore.. causes lots of problems :( See https://github.com/github/hubot/tree/master/docs#getting-started-with-hubot for notes on the new usage.

I'd propose having some example scripts that really are examples, rather than ones that have real functionality.

It's been a while since I used npm for anything, but aren't they installed in a dot directory locally or in your user directory somewhere? That doesn't feel like as pleasant of a first run experience. :(

Yep. If you've created a new hubot, bin/hubot takes care of running npm install to install dependencies. This includes hubot-scripts, which has scripts included by default in hubot-scripts.json.

technicalpickles added a commit that referenced this pull request Dec 31, 2013
@technicalpickles technicalpickles merged commit 96a1f0b into hubotio:master Dec 31, 2013
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants