Update agents.md #2070
Open
Update agents.md #2070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix bad typing in RetrieverTool class
pcuenca
reviewed
May 15, 2024
| @@ -184,7 +184,7 @@ class RetrieverTool(Tool): | |||
| } | |||
| output_type = "text" | |||
|
|
|||
| def __init__(self, vectordb: VectorStore, all_sources: str, **kwargs): | |||
| def __init__(self, vectordb: VectorStore, all_sources: list[str], **kwargs): | |||
There was a problem hiding this comment.
Actually, the comment in L191 says it's a string representation of a list, but both that and a list should work. cc @aymeric-roucher to use whichever one he thinks it's best.
There was a problem hiding this comment.
Both List[str] and str should work, so this line could be Union[str, List[str]]!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bad typing in RetrieverTool class