-
Notifications
You must be signed in to change notification settings - Fork 877
add more benchmark numbers #2900
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
add more benchmark numbers #2900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. I think for torchao
, we could additionally mention the FP8 numbers on RTX 4090. WDYT?
diffusers-quantization.md
Outdated
@@ -450,7 +450,7 @@ For more information check out the [Layerwise casting docs](https://huggingface. | |||
|
|||
Most of these quantization backends can be combined with the memory optimization techniques offered in Diffusers. Let's explore CPU offloading, group offloading, and `torch.compile`. You can learn more about these techniques in the [Diffusers documentation](https://huggingface.co/docs/diffusers/main/en/optimization/memory). | |||
|
|||
> **Note:** At the time of writing, bnb + `torch.compile` also works if bnb is installed from source and using pytorch nightly or with fullgraph=False. | |||
> **Note:** At the time of writing, bnb + `torch.compile` works if bnb is installed from source and using pytorch nightly or with fullgraph=False. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/bitsandbytes-foundation/bitsandbytes/releases/tag/0.46.0 is done so bitsandbytes==0.46.0
should work with PyTorch nightly.
diffusers-quantization.md
Outdated
@@ -565,6 +592,13 @@ pipe = FluxPipeline.from_pretrained( | |||
| int8_weight_only | 17.020 GB | 22.473 GB | 8 seconds | ~851 seconds | | |||
| float8_weight_only | 17.016 GB | 22.115 GB | 8 seconds | ~545 seconds | | |||
|
|||
**bitsandbytes + `torch.compile`**: **Note:** To enable compatibility with torch.compile, make sure you're using the latest version of bitsandbytes and PyTorch nightlies (2.8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention the hardware this was obtained on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what hardware this was obtained on? was it A100?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
H100.
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Hmm, I'm not sure. RTX 4090 is probably more common for developers, but could make blogpost more complex |
In the diffusion world, RTX 4090 is more common than A100, H100, etc., actually. But okay without. |
@sayakpaul