Skip to content

add more benchmark numbers #2900

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DerekLiu35
Copy link
Contributor

@DerekLiu35 DerekLiu35 commented Jun 10, 2025

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. I think for torchao, we could additionally mention the FP8 numbers on RTX 4090. WDYT?

@@ -450,7 +450,7 @@ For more information check out the [Layerwise casting docs](https://huggingface.

Most of these quantization backends can be combined with the memory optimization techniques offered in Diffusers. Let's explore CPU offloading, group offloading, and `torch.compile`. You can learn more about these techniques in the [Diffusers documentation](https://huggingface.co/docs/diffusers/main/en/optimization/memory).

> **Note:** At the time of writing, bnb + `torch.compile` also works if bnb is installed from source and using pytorch nightly or with fullgraph=False.
> **Note:** At the time of writing, bnb + `torch.compile` works if bnb is installed from source and using pytorch nightly or with fullgraph=False.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/bitsandbytes-foundation/bitsandbytes/releases/tag/0.46.0 is done so bitsandbytes==0.46.0 should work with PyTorch nightly.

@@ -565,6 +592,13 @@ pipe = FluxPipeline.from_pretrained(
| int8_weight_only | 17.020 GB | 22.473 GB | 8 seconds | ~851 seconds |
| float8_weight_only | 17.016 GB | 22.115 GB | 8 seconds | ~545 seconds |

**bitsandbytes + `torch.compile`**: **Note:** To enable compatibility with torch.compile, make sure you're using the latest version of bitsandbytes and PyTorch nightlies (2.8)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention the hardware this was obtained on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what hardware this was obtained on? was it A100?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H100.

DerekLiu35 and others added 3 commits June 9, 2025 22:30
@DerekLiu35
Copy link
Contributor Author

Thanks for the updates. I think for torchao, we could additionally mention the FP8 numbers on RTX 4090. WDYT?

Hmm, I'm not sure. RTX 4090 is probably more common for developers, but could make blogpost more complex

@sayakpaul
Copy link
Member

sayakpaul commented Jun 10, 2025

In the diffusion world, RTX 4090 is more common than A100, H100, etc., actually. But okay without.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants