Skip to content

[LoRA] depcrecate save_attn_procs(). #10126

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

sayakpaul
Copy link
Member

What does this PR do?

Should have been done in #9712 but somehow got missed.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the warning.

assert check_if_lora_correctly_set(model), "Lora not correctly set in UNet."

with tempfile.TemporaryDirectory() as tmpdirname:
with self.assertWarns(FutureWarning) as warning:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use assertWarnsRegex to check the message.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use assertWarns throughout diffusers. So, just kept that for consistency.

@yiyixuxu yiyixuxu merged commit fa3a910 into main Dec 6, 2024
18 checks passed
@yiyixuxu yiyixuxu deleted the deprecate-save-attn-procs branch December 6, 2024 20:39
sayakpaul added a commit that referenced this pull request Dec 23, 2024
depcrecate save_attn_procs().
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants