[LoRA] fix indexing in LoRA state dict expansion utils #10396
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We introduced a bug in
diffusers/src/diffusers/loaders/lora_pipeline.py
Line 2471 in 83da817
This makes the following code throw errors with the latest
diffusers
:Reproducer
This went uncaught because we don't have a test to mimic this scenario.
So, this PR fixes this behavior and also adds a test for it.
I think we have to do a patch release for this (which I can take care of). Related to #10392.