-
Notifications
You must be signed in to change notification settings - Fork 6k
Add community class StableDiffusionXL_T5Pipeline #11626
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Will be used with base model opendiffusionai/stablediffusionxl_t5
PS: This code was tested locally and ran, using the following test harness:
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@bot /style |
thanks @ppbrown , can you add some simple information to the README so people will know what this pipeline is, just a description and maybe a link to your experiment? |
also the style bot didn't work, can you run |
I committed the tweaks from "make style". "make quality" didnt seem to do anything, I think? I looked at the README_contrib..... file, but.... the existing formatting in that made my eyes bleed and my head hurt :( |
yeah, probably that file is too big right now and not easy to modify and read, maybe we should think a better way to maintain this @stevhliu WDTY of just a index file that points to an individual README for each community pipeline? this way people can just read directly the readme for the pipeline they want to use. |
There are already a LOT of files in that directory. IMO, a better approach might be: redo the README_community as a SINGLE LINE summary of each file. eg: |filename| 100-char max descrption| And then come up with a docstring standard expected format for a comment inside each pipeline, for more details. Alternatively, go with the seperate README file for each, but make them live in a "docs" subdir. |
@bot /style |
Style fixes have been applied. View the workflow run here. |
yeah I don't have a strong opinion about how to maintain it more simple and clean so anything works for me, probably not the best idea to impose some conditions for it like a specific format for the docstrings or README since the idea for this section is to people to contribute without the need to maintain a strict guideline. let's wait for @stevhliu opinion about this., this is not a merge blocker, just something for the future. |
@ppbrown thanks a lot! |
I agree something simple and clean works best. Maybe just keep the table short and entirely get rid of the
|
I for one have no idea how to use "notebooks", so that would be an annoying barrier to entry for me. |
What does this PR do?
This adds a new community pipeline, named
StableDiffusionXL_T5Pipeline
It grafts the T5 xxl encoder onto SDXL, completely replacing TE1 and TE2.
It has been tested to produce output. However, the output isnt particularly valid.
The unet needs to be retrained.
Will initially be used with base model opendiffusionai/stablediffusionxl_t5
until a proper (re)fine-tune can be made.
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?