[Docs] Update and make improvements
#5819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
stevhliu
approved these changes
Nov 16, 2023
|
I guess the type of timesteps should be strictly int64. The default type might be different from system to system. I should have posed the question why did someone put |
a-r-r-o-w
pushed a commit
to a-r-r-o-w/diffusers
that referenced
this pull request
Nov 20, 2023
* Revert "[`Docs`] Update and make improvements (huggingface#5819)" This reverts commit c697f52. * Update README.md * Update memory.md * Update basic_training.md * Update write_own_pipeline.md * Update fp16.md * Update basic_training.md * Update write_own_pipeline.md * Update write_own_pipeline.md
affromero
pushed a commit
to affromero/diffusers
that referenced
this pull request
Nov 24, 2023
* Revert "[`Docs`] Update and make improvements (huggingface#5819)" This reverts commit c697f52. * Update README.md * Update memory.md * Update basic_training.md * Update write_own_pipeline.md * Update fp16.md * Update basic_training.md * Update write_own_pipeline.md * Update write_own_pipeline.md
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
Update and make improvements
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* Revert "[`Docs`] Update and make improvements (huggingface#5819)" This reverts commit c697f52. * Update README.md * Update memory.md * Update basic_training.md * Update write_own_pipeline.md * Update fp16.md * Update basic_training.md * Update write_own_pipeline.md * Update write_own_pipeline.md
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creating tensors directly on the GPU is ~22 times, and creating them directly as half-precision is ~4 times faster.
-- Experiment environment:
-- CPU: AMD Ryzen 5 3550H
-- GPU: NVIDIA GeForce GTX 1650 Mobile / Max-Q
-- Platform: Linux-6.2.0-36-generic-x86_64-with-glibc2.35
-- Python version: 3.10.12
-- PyTorch version: 2.1.1
Of course, at the end of the day, the time for creating tensors in the docs doesn't create a visible difference, but I edited them as best practices.
Removed .long() castings because the tensors were already created .long() format by default.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@stevhliu @yiyixuxu @DN6