LLMGroundedDiffusionPipeline: inherit from DiffusionPipeline and fix peft #6023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
yiyixuxu
approved these changes
Dec 1, 2023
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…peft (huggingface#6023) * LLMGroundedDiffusionPipeline: inherit from DiffusionPipeline and fix peft * Use main in the revision in the examples * Add "Copied from" statements in comments * Fix formatting with ruff
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As discussed with @yiyixuxu in #5993, we would like to inherit from
DiffusionPipelinerather thanStableDiffusionPipeline.This PR also fixes the PEFT issue mentioned by @stevhliu .
This PR updates the example to use the
mainrevision so that it uses the fixed pipeline without requiringdiffusersupdate.Tested locally that it works with
diffusers==0.24.0withpeft==0.6.2and without peft.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@yiyixuxu @stevhliu