Reflect few contributions on philosophy.md that were not reflected on #8294
#8690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some contributions were not reflected previously, so I am resubmitting them.
sayakpaul
requested review from
yiyixuxu and
stevhliu
and removed request for
yiyixuxu
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
|
@mreraser Looks good this time, thanks for the fix, change draft to open and request a merge! |
Thank you @heuristicwave for your review! Have a nice day 👍 |
6 tasks
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
#8294 (#8690) * Update philosophy.md Some contributions were not reflected previously, so I am resubmitting them. * Update docs/source/ko/conceptual/philosophy.md Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * Update docs/source/ko/conceptual/philosophy.md Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hello!😀
In the previous PR, I mistakenly named the file
philosopy.mdand later corrected it tophilosophy.md.However, during this process, it was identified by @heuristicwave that the reviews provided by @jungnerd were not reflected in the PR. I apologize for the oversight and any inconvenience caused. I should have double-checked before the PR was merged.
I am resubmitting the PR with the latest changes included. Thank you for your understanding.
from #7940
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@heuristicwave @stevhliu