allow tensors in several schedulers step() call #8905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix typing of the
timesteps
argument of schedulers taking an integer to also allow tensors. The timestep is passed to_init_step_index
which deals with this case.I did not change the docstrings to "
int
ortorch.Tensor
", I can do it if you want (but most other schedulers that already support tensors do not mention it in the docstring).Note: I kept this PR minimal and did not try to change any actual code, but the typing of timesteps in schedulers is a bit messy. For instance several schedulers initialize
self.timesteps
as a floating-point tensor but use an integer tensor inset_timesteps
.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Maybe @yiyixuxu since this is about schedulers.