notebook_login errors out after passing token in main branch

[merveenoyan]

Describe the bug

I installed main branch of huggingface_hub because I needed to use dataset conversion tool where you can see huggingface_hub main branch in requirements.txt. The notebook_login errors out with logs below. This doesn't happen when I update last version of the library.

Reproduction

You can try this notebook. I tried only installing github repository itself and calling notebook_login and was able to reproduce it.

Logs

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
/usr/local/lib/python3.7/dist-packages/huggingface_hub/commands/user.py in login_token_event(t)
    308         token_widget.value = ""
    309         clear_output()
--> 310         _login(token=token)
    311 
    312     token_finish_button.on_click(login_token_event)

TypeError: _login() missing 1 required positional argument: 'hf_api'

System Info

(Below is tip of main branch)

huggingface-hub @ git+https://github.com/huggingface/huggingface_hub@3a59bf13f1ef50b2e7e9ac8362f5984ac288eb33

[Wauplin]

Hi @merveenoyan , thanks for reporting ! This regression has been introduced by #1064. I fixed it here: #1073. Sorry for that but very happy you noticed it before any release :D

[Wauplin]

In the meantime, you can pip install from 26819c73a47e56a53a2e047d540c0c456d31d70c

[merveenoyan]

@Wauplin the last release works just fine, it's just the tool I mentioned in the issue is using main branch and that was my initial problem. If I revert to latest release the tool just won't work, that's why I didn't want to use that branch.

[Wauplin]

Merged :)

[nateraw]

@merveenoyan Did installing the latest release solve the problem for you while using the datasets converter? (v0.10.0rc0)

It did not solve the problem for me, I think, which is concerning.

[Wauplin]

@nateraw I haven't used the datasets converter tool but here is a simple colab where notebook_login works correctly on 0.10.0rc0. Could you check huggingface_hub is correctly installed ?

pip uninstall huggingface_hub
pip install huggingface_hub==0.10.0rc0

[osanseviero]

The login does work for me when installing from head

[nateraw]

The issue was fixed with this PR I believe. Thanks all!!