Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FIX notebook login #1073

Merged
merged 1 commit into from
Sep 22, 2022
Merged

FIX notebook login #1073

merged 1 commit into from
Sep 22, 2022

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Sep 22, 2022

Fix #1072.

This could have been reported by mypy but we don't automate that yet ><. Not sure how to test a jupyter widget otherwise :/

@Wauplin Wauplin requested a review from merveenoyan September 22, 2022 12:22
Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work, thanks a lot for fixing it!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 22, 2022

The documentation is not available anymore as the PR was closed or merged.

@Wauplin
Copy link
Contributor Author

Wauplin commented Sep 22, 2022

I tried it locally before pushing ! But we should find a way to automate testing on notebook_login :/

@merveenoyan
Copy link
Contributor

FYI I found repository that provides demos on testing jupyter widgets 😅

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 84.16% // Head: 84.16% // No change to project coverage 👍

Coverage data is based on head (696d507) compared to base (3a59bf1).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1073   +/-   ##
=======================================
  Coverage   84.16%   84.16%           
=======================================
  Files          40       40           
  Lines        4087     4087           
=======================================
  Hits         3440     3440           
  Misses        647      647           
Impacted Files Coverage Δ
src/huggingface_hub/commands/user.py 33.75% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Wauplin
Copy link
Contributor Author

Wauplin commented Sep 22, 2022

Cool thanks, I'll definitely look into it :)

@Wauplin Wauplin merged commit df90bdd into main Sep 22, 2022
@Wauplin Wauplin deleted the 1072-fix-notebook-login branch September 22, 2022 12:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notebook_login errors out after passing token in main branch
3 participants