-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support python=3.10 #786
Comments
It should just be as simple as changing python-tests.yml matrix to be 3.7 and 3.10 for the python versions, rather than 3.6 and 3.9. Not sure if anything would break, but that'd be the spot for the CI |
If we deprecate python 3.6, things can probably simplify in some places as well cc @omarespejel and @merveenoyan |
Python 3.10: Definitely, let's update the CI to use 3.10 instead. Python 3.6: As this package is a dependency for a lot of libraries, we ought to check with the downstream libraries to see if they don't still support 3.6:
@osanseviero let me know if I have missed some! Given that a lot of these still support 3.6, I would advocate to wait for at least 1-2 months before dropping support so as to not be the vector of change. We also have a significant number of users (~10%) still using (from https://pypistats.org/packages/huggingface-hub) Of course, for security concerns and for simplicity we'll switch to 3.7 sooner rather than later. |
The list seems complete! Just to add, most (hopefully all) of those have a pinned |
I think a more relevant question would be if there is any package having dependencies on But also as @osanseviero mentions, this doesn't change older versions and users can still install the older ones if the need py=3.6 support. They usually don't even notice the issue since |
Python 3.10 has been out for a while but we seem to not test for it. What are the roadblocks for us to support 3.10 and maybe deprecate 3.6? (Many packages now support 3.8-3.10 and older versions are not supported anymore).
Ping @LysandreJik @osanseviero maybe?
The text was updated successfully, but these errors were encountered: