Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CI support python 3.7-3.10 - remove 3.6 support #790

Merged
merged 2 commits into from
Mar 24, 2022
Merged

CI support python 3.7-3.10 - remove 3.6 support #790

merged 2 commits into from
Mar 24, 2022

Conversation

adrinjalali
Copy link
Contributor

@adrinjalali adrinjalali commented Mar 23, 2022

This PR removes tests on 3.6 and adds 3.10 support on the CI.

Fixes #786

@adrinjalali
Copy link
Contributor Author

All green.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given comments in #786 and that Python 3.6 has reached EOL.

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@LysandreJik LysandreJik merged commit 6517aab into huggingface:main Mar 24, 2022
@adrinjalali adrinjalali deleted the 310 branch March 24, 2022 11:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support python=3.10
3 participants